IBX-6724: Simplify context menu #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tischsoic
force-pushed
the
IBX-6724-simplify-context-menus
branch
from
b98d196 to
77fe15d
Compare
tischsoic
force-pushed
the
IBX-6724-simplify-context-menus
branch
from
77fe15d to
353d468
Compare
webhdx
approved these changes
Jan 10, 2024
konradoboza
reviewed
Jan 10, 2024
ViniTou
approved these changes
Jan 10, 2024
Steveb-p
approved these changes
Jan 10, 2024
konradoboza
approved these changes
Jan 10, 2024
alongosz
approved these changes
Jan 10, 2024
Comment on lines
+107
to
+108
| if ($form->getClickedButton() instanceof Button | ||
| && $form->getClickedButton()->getName() === UserSettingUpdateType::BTN_UPDATE_AND_EDIT |
There was a problem hiding this comment.
Nitpick: it's usually more optimal to extract $form->getClickedButton() instead of calling it twice, unless it's a property getter.
tischsoic
force-pushed
the
IBX-6724-simplify-context-menus
branch
from
f41a935 to
e77c98b
Compare
|
barbaragr
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)