IBX-8470: Upgraded codebase to Symfony 6 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Nov 28, 2024
Steveb-p
approved these changes
Dec 17, 2024
| @@ -28,6 +28,7 @@ services: | |||
|
|
|||
| Ibexa\Bundle\User\Controller\UserRegisterController: | |||
| autowire: true | |||
| autoconfigure: true | |||
There was a problem hiding this comment.
Considering other controllers in the file did not receive this change, and that this tags were already applied to the service declaration, what is the difference? What in particular was missing (not autoconfigured)?
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> | ||
| <coverage> | ||
| <include> | ||
| <directory>src</directory> |
There was a problem hiding this comment.
Suggested change
| <directory>src</directory> | |
| <directory suffix=".php">src</directory> |
20 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a part of bigger set of changes, to be merged together when ready
Related PRs:
Description:
This PR bumps Symfony to v6 with necessary and optional codebase upgrades. Updated also PHPUnit configuration.
Key changes:
QA:
Sanities in the form of regression tests.
Documentation:
No documentation required.