Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for individual rounded corners in the experimental backend #5

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Philipp-M
Copy link

@Philipp-M Philipp-M commented Aug 13, 2020

This PR adds support for individual rounded corners, to be able to achieve the effect as discussed in my previous comment: yshui#361 (comment)

Each rounded corner can be configured per window like corner-radius using the new config options corner-radius-top-left, corner-radius-top-right, corner-radius-bottom-right and corner-radius-bottom-left.

Though because the old backends are deprecated someday in the future I haven't added support for them.

@ibhagwan
Copy link
Owner

Chapeau @Philipp-M, this is a really neat implementation converting u_radius to vec4 and modifying the RectSDF function, gotta love open source :-)

@snoweuph
Copy link

snoweuph commented Nov 9, 2022

soo, are Individual Rounded Corners for Individual Windows are in work?

@Philipp-M
Copy link
Author

This is quite old and has diverged quite a bit from the original repo.
It should be rebased onto the original repo (and probably implement this as well for other backends) but I don't have the time to do that, maybe someone else wants to try?

@ibhagwan
Copy link
Owner

This is quite old and has diverged quite a bit from the original repo. It should be rebased onto the original repo (and probably implement this as well for other backends) but I don't have the time to do that, maybe someone else wants to try?

Most of the functionality (maybe all by now?) of this fork is now merged upstream, if someone wants to do it they should probably rebase this PR on the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants