Avoid duplicate descriptions in calendars #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
dev
before they can be merged tomaster
)Description
The default description for a calendar in GTFS-lib will be autopopulated with a concatenation of the days of service it operates on. However, if multiple calendars operate on the same set of days, this will create duplicate descriptions which can become an issue for the datatools-ui display. This PR conditionally overrides any duplicates with the service-id, which is at least more useful than displaying duplicates.
You can test this with datatools-server set up to use this gtfs-lib hash and the latest datatools-ui.