Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exception Based Service Trip ID update #3

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix Exception Based Service Trip ID update #3

merged 1 commit into from
Nov 30, 2023

Conversation

philip-cline
Copy link

@philip-cline philip-cline commented Nov 29, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Small bug in the trip service ID update for exception based service.

br648
br648 approved these changes Nov 29, 2023
View reviewed changes
Copy link

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, good fix.

@br648 br648 assigned philip-cline and unassigned br648 Nov 29, 2023
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Nov 29, 2023
View reviewed changes
Copy link

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Glad we fixed that on

@philip-cline philip-cline merged commit e12dcf8 into dev Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@philip-cline philip-cline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-cline @br648 @miles-grant-ibigroup