Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stop deletion error #4

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix stop deletion error #4

merged 1 commit into from
Dec 21, 2023

Conversation

philip-cline
Copy link

@philip-cline philip-cline commented Dec 20, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

A recent merge caused the stop deletion error to be missing some required data. This PR reverts that.

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Dec 20, 2023
View reviewed changes
Copy link

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix thank you!

br648
br648 approved these changes Dec 21, 2023
View reviewed changes
Copy link

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! I'm not surprised it was in this class.

@vilmosnagy
Copy link

vilmosnagy commented Dec 21, 2023 •
edited
Loading

we've jut run into this issue. any chance this get merged (& updated in datatools-server) in the coming days? thanks.

@philip-cline philip-cline merged commit 3fa0da9 into dev Dec 21, 2023
2 checks passed
@philip-cline
Copy link
Author

Hi @vilmosnagy, we will bump the gtfs-lib version for datatools-server in a new PR shortly. That should provide you with the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@br648 br648 br648 approved these changes

Assignees

@philip-cline philip-cline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@philip-cline @vilmosnagy @br648 @daniel-heppner-ibigroup @binh-dam-ibigroup @miles-grant-ibigroup