Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add kaggle example #122

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

jitingxu1
Copy link
Collaborator

Add example: Home Credit - Credit Risk Model Stability link

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (26b704a) to head (9eeea68).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   84.54%   84.94%   +0.40%     
==========================================
  Files          24       26       +2     
  Lines        1863     1920      +57     
==========================================
+ Hits         1575     1631      +56     
- Misses        288      289       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jitingxu1 jitingxu1 requested a review from deepyaman June 27, 2024 20:46
@deepyaman deepyaman changed the title example: add kaggle example [WIP] docs(examples): add kaggle example Jul 1, 2024
@deepyaman
Copy link
Collaborator

deepyaman commented Jul 1, 2024

To be updated based on blog post content/review. Marked WIP in the meantime.

@deepyaman deepyaman marked this pull request as draft July 1, 2024 18:49
@jitingxu1 jitingxu1 marked this pull request as ready for review August 23, 2024 21:23
@jitingxu1 jitingxu1 changed the title [WIP] docs(examples): add kaggle example docs(examples): add kaggle example Aug 23, 2024
Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Couple minor things I noticed (other than the suggestion to rename):

  • You have one more instance of ROOT = Path("/Users/claypot/Downloads/home-credit-credit-risk-model-stability"); do you just want to rename claypot to jitingxu or something there?
  • No need to do this in this PR, or with any priority, but I think it would be ideal to use %%bash cells and render the output instead of ```bash``` in Markdown (and writing out the outputs).

Feel free to merge as is, or with the suggested notebook rename + claypot->jitingxu or something; leave it up to you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think Using IbisML and DuckDB for a Kaggle competition.ipynb is a more descriptive title, like you have in your post. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will change the title and minor thing you mentioned in the above thread.

@jitingxu1 jitingxu1 merged commit 2f2aaaf into ibis-project:main Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants