-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add kaggle example #122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 84.54% 84.94% +0.40%
==========================================
Files 24 26 +2
Lines 1863 1920 +57
==========================================
+ Hits 1575 1631 +56
- Misses 288 289 +1 ☔ View full report in Codecov by Sentry. |
To be updated based on blog post content/review. Marked WIP in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Couple minor things I noticed (other than the suggestion to rename):
- You have one more instance of
ROOT = Path("/Users/claypot/Downloads/home-credit-credit-risk-model-stability")
; do you just want to renameclaypot
tojitingxu
or something there? - No need to do this in this PR, or with any priority, but I think it would be ideal to use
%%bash
cells and render the output instead of ```bash``` in Markdown (and writing out the outputs).
Feel free to merge as is, or with the suggested notebook rename + claypot->jitingxu or something; leave it up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think Using IbisML and DuckDB for a Kaggle competition.ipynb
is a more descriptive title, like you have in your post. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I will change the title and minor thing you mentioned in the above thread.
Add example: Home Credit - Credit Risk Model Stability link