Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(steps): fix wrong name for timestamp selector #139

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

deepyaman
Copy link
Collaborator

@deepyaman deepyaman commented Aug 23, 2024

Resolves #134

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (80881f8) to head (7d2e32f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files          26       26           
  Lines        1920     1920           
=======================================
  Hits         1631     1631           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepyaman
Copy link
Collaborator Author

@jcrist @jitingxu1 Do you have any thoughts about the step being called ExpandDateTime? Ibis seems to use the name Timestamp instead of DateTime, so I'm thinking about renaming it to ExpandTimestamp.

@jitingxu1
Copy link
Collaborator

@jcrist @jitingxu1 Do you have any thoughts about the step being called ExpandDateTime? Ibis seems to use the name Timestamp instead of DateTime, so I'm thinking about renaming it to ExpandTimestamp.

it works for me.

Copy link
Collaborator

@jitingxu1 jitingxu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jitingxu1 jitingxu1 merged commit 0084273 into ibis-project:main Aug 26, 2024
4 checks passed
@deepyaman deepyaman deleted the docs/steps/fix-selector-name branch August 27, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibis_ml has no attribute datetime
3 participants