Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): fix possible name collision in train_test_split #142

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

jitingxu1
Copy link
Collaborator

solve #138

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (80881f8) to head (4d462f7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   84.94%   85.39%   +0.44%     
==========================================
  Files          26       26              
  Lines        1920     1924       +4     
==========================================
+ Hits         1631     1643      +12     
+ Misses        289      281       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ibis_ml/utils/_split.py Outdated Show resolved Hide resolved
@deepyaman deepyaman changed the title fix(utils): fix possible name collision in train_test_split fix(utils): fix possible name collision in train_test_split Sep 13, 2024
@deepyaman deepyaman merged commit 6582682 into ibis-project:main Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants