Refactor for better sklearn compatibility #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major API refactor, intended to accomplish the following: - Reduce the number of named objects and concepts, simplifying the user-facing API. - Improve compatibility with `sklearn`. The goal here is not to be a drop-in API for `sklearn`, instead the goal is to be able to integrate `ibisml` into `sklearn` workflows. With this refactor you should be able to include a `ibisml.Recipe` as a step within an existing `sklearn` pipeline and have things "just work". - Still support usage outside of sklearn workflows. We don't want to force users to fit the sklearn model, but given sklearn is a common standard within the python ecosystem, it'd be good to make the common case simpler.
deepyaman
reviewed
Mar 7, 2024
This is part of implementing the Scikit-Learn standard interface.
Also fixes a few bugs
jcrist
changed the title
|
Our test coverage could still use some work, but for now this is strictly an improvement on the prior state. I'm going to merge this now and we can continue iteratively improving things in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major API refactor, intended to accomplish the following:
sklearn. The goal here is not to be a drop-in API forsklearn, instead the goal is to be able to integrateibismlintosklearnworkflows. With this refactor you should be able to include aibisml.Recipeas a step within an existingsklearnpipeline and have things "just work".Still TODO: