feat(snowflake): allow empty url when using ibis.connect (#8428)

Follow-up to #8422 to support that behavior in `ibis.connect()`.
ibis-project · Feb 22, 2024 · 0275c9b · 0275c9b
1 parent ad1f53a
commit 0275c9b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/ibis/backends/snowflake/__init__.py b/ibis/backends/snowflake/__init__.py
@@ -106,17 +106,21 @@ def _from_url(self, url: str, **kwargs):
         """
 
         url = urlparse(url)
-        database, schema = url.path[1:].split("/", 1)
-        query_params = parse_qs(url.query)
-        (warehouse,) = query_params.pop("warehouse", (None,))
-        connect_args = {
-            "user": url.username,
-            "password": url.password or "",
-            "account": url.hostname,
-            "warehouse": warehouse,
-            "database": database or "",
-            "schema": schema or "",
-        }
+        if url.path:
+            database, schema = url.path[1:].split("/", 1)
+            query_params = parse_qs(url.query)
+            (warehouse,) = query_params.pop("warehouse", (None,))
+            connect_args = {
+                "user": url.username,
+                "password": url.password or "",
+                "account": url.hostname,
+                "warehouse": warehouse,
+                "database": database or "",
+                "schema": schema or "",
+            }
+        else:
+            connect_args = {}
+            query_params = {}
 
         for name, value in query_params.items():
             if len(value) > 1:

diff --git a/ibis/backends/snowflake/tests/test_client.py b/ibis/backends/snowflake/tests/test_client.py
@@ -301,3 +301,6 @@ def test_compile_does_not_make_requests(con, mocker):
 def test_no_argument_connection():
     con = ibis.snowflake.connect()
     assert con.list_tables() is not None
+
+    con = ibis.connect("snowflake://")
+    assert con.list_tables() is not None