Skip to content

Commit

Permalink
fix(impala): a delimited table explicitly declare stored as textfile
Browse files Browse the repository at this point in the history
fixes #4260
  • Loading branch information
yi-you authored and cpcloud committed Jul 23, 2022
1 parent f5f7f90 commit 04086a4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions ibis/backends/impala/ddl.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def to_ddl(self):
if self.lineterminator is not None:
yield f"LINES TERMINATED BY '{self.lineterminator}'"

yield 'STORED AS TEXTFILE'
yield f"LOCATION '{self.path}'"

if self.na_rep is not None:
Expand Down
1 change: 1 addition & 0 deletions ibis/backends/impala/tests/test_ddl_compilation.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ def test_create_table_delimited():
FIELDS TERMINATED BY '|'
ESCAPED BY '\\'
LINES TERMINATED BY '\0'
STORED AS TEXTFILE
LOCATION '{}'""".format(
path
)
Expand Down

1 comment on commit 04086a4

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: 04086a4 Previous: f5f7f90 Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_compile[small-postgres] 1002.1330303308248 iter/sec (stddev: 0.007936209048232787) 6854.8474261571655 iter/sec (stddev: 0.0000422757471820683) 6.84

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.