feat(snowflake): string to timestamp

ibis-project · Jan 19, 2023 · 095ded6 · 095ded6
1 parent 035f856
commit 095ded6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -225,6 +225,7 @@ def _map(_, op):
         ops.BitOr: reduction(sa.func.bitor_agg),
         ops.BitXor: reduction(sa.func.bitxor_agg),
         ops.DateFromYMD: fixed_arity(sa.func.date_from_parts, 3),
+        ops.StringToTimestamp: fixed_arity(sa.func.to_timestamp_tz, 2),
     }
 )
 
@@ -250,7 +251,6 @@ def _map(_, op):
     # ibis.expr.operations.temporal
     ops.ExtractMillisecond,
     ops.IntervalFromInteger,
-    ops.StringToTimestamp,
     ops.TimestampDiff,
     ops.TimestampFromUNIX,
     ops.TimestampFromYMDHMS,

diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -636,7 +636,8 @@ def test_integer_to_timestamp(backend, con, unit):
             '%m/%d/%y',
             id="mysql_format",
             marks=pytest.mark.never(
-                ["pyspark"], reason="datetime formatting style not supported"
+                ["pyspark", "snowflake"],
+                reason="datetime formatting style not supported",
             ),
         ),
         param(
@@ -658,7 +659,6 @@ def test_integer_to_timestamp(backend, con, unit):
         'sqlite',
         'impala',
         'datafusion',
-        'snowflake',
         'mssql',
     ]
 )