Skip to content

Commit

Permalink
fix(duckdb): use regexp_matches to ensure that matching checks contai…
Browse files Browse the repository at this point in the history 
…nment instead of a full match
  • Loading branch information
@cpcloud
cpcloud committed Jul 8, 2023
1 parent 007d00d commit 0a0cda6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ibis/backends/duckdb/registry.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def _try_cast(t, op):
ops.RegexReplace: fixed_arity(
lambda *args: sa.func.regexp_replace(*args, sa.text("'g'")), 3
),
ops.RegexSearch: fixed_arity(lambda x, y: x.op("SIMILAR TO")(y), 2),
ops.RegexSearch: fixed_arity(sa.func.regexp_matches, 2),
ops.StringContains: fixed_arity(sa.func.contains, 2),
ops.ApproxMedian: reduction(
# without inline text, duckdb fails with
Expand Down

1 comment on commit 0a0cda6

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: 0a0cda6 Previous: 6278edf Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_compile[small-clickhouse] 1124.4461981999343 iter/sec (stddev: 0.009001122024169096) 4953.461055076046 iter/sec (stddev: 0.00004740638514904838) 4.41

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.