feat(exasol): add support for ExtractQuarter (#8587)

ibis-project · Mar 8, 2024 · 0d9b676 · 0d9b676
1 parent 16e8b95
commit 0d9b676
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ibis/backends/exasol/compiler.py b/ibis/backends/exasol/compiler.py
@@ -59,7 +59,6 @@ class ExasolCompiler(SQLGlotCompiler):
             ops.DayOfWeekName,
             ops.ElementWiseVectorizedUDF,
             ops.ExtractEpochSeconds,
-            ops.ExtractQuarter,
             ops.ExtractWeekOfYear,
             ops.First,
             ops.IntervalFromInteger,
@@ -180,3 +179,6 @@ def visit_DateDelta(self, op, *, part, left, right):
 
     def visit_ExtractDayOfYear(self, op, *, arg):
         return self.cast(self.f.to_char(arg, "DDD"), op.dtype)
+
+    def visit_ExtractQuarter(self, op, *, arg):
+        return self.cast(self.f.to_char(arg, "Q"), op.dtype)
diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -77,7 +77,6 @@ def test_date_extract(backend, alltypes, df, attr, expr_fn):
             "quarter",
             marks=[
                 pytest.mark.notyet(["oracle"], raises=OracleDatabaseError),
-                pytest.mark.notimpl(["exasol"], raises=com.OperationNotDefinedError),
             ],
         ),
         "hour",
-Original file line number
+Diff line change
@@ Expand Up / @@ -77,7 +77,6 @@ def test_date_extract(backend, alltypes, df, attr, expr_fn): @@
                 "quarter",
                 marks=[
                     pytest.mark.notyet(["oracle"], raises=OracleDatabaseError),
-                    pytest.mark.notimpl(["exasol"], raises=com.OperationNotDefinedError),
                 ],
             ),
             "hour",
@@ Expand Down @@