fix(clickhouse): disconnect from clickhouse when computing version

ibis-project · Feb 8, 2022 · 11cbf08 · 11cbf08
1 parent d81cef8
commit 11cbf08
Show file tree

Hide file tree

Showing 2 changed files with 98 additions and 84 deletions.
diff --git a/ibis/backends/clickhouse/__init__.py b/ibis/backends/clickhouse/__init__.py
@@ -104,9 +104,8 @@ def version(self) -> str:
         self.con.connection.force_connect()
         try:
             info = self.con.connection.server_info
-        except Exception:
+        finally:
             self.con.connection.disconnect()
-            raise
 
         return f'{info.version_major}.{info.version_minor}.{info.revision}'