fix(datafusion): cast division inputs to float64 before dividing

ibis-project · Sep 19, 2023 · 197342d · 197342d · ibis-squawk-bot · Sep 19, 2023
1 parent d039809
commit 197342d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ibis/backends/datafusion/compiler.py b/ibis/backends/datafusion/compiler.py
@@ -371,7 +371,9 @@ def mul(op, **kw):
 
 @translate.register(ops.Divide)
 def div(op, **kw):
-    return translate(op.left, **kw) / translate(op.right, **kw)
+    left = translate(ops.Cast(op.left, to=dt.float64), **kw)
+    right = translate(ops.Cast(op.right, to=dt.float64), **kw)
+    return left / right
 
 
 @translate.register(ops.FloorDivide)

diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py
@@ -1261,9 +1261,7 @@ def test_floating_mod(backend, alltypes, df):
         ),
     ],
 )
-@pytest.mark.notyet(
-    ["datafusion", "duckdb", "mysql", "pyspark", "sqlite"], raises=AssertionError
-)
+@pytest.mark.notyet(["duckdb", "mysql", "pyspark", "sqlite"], raises=AssertionError)
 @pytest.mark.notyet(["mssql"], raises=sa.exc.OperationalError)
 @pytest.mark.notyet(["postgres"], raises=sa.exc.DataError)
 @pytest.mark.notyet(["snowflake"], raises=sa.exc.ProgrammingError)