fix(mssql): remove invalid aggregations

ibis-project · Mar 16, 2023 · 1ce3ef9 · 1ce3ef9
1 parent 3dffff7
commit 1ce3ef9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 24 deletions.
diff --git a/ibis/backends/mssql/registry.py b/ibis/backends/mssql/registry.py
@@ -195,6 +195,11 @@ def _timestamp_truncate(t, op):
     # ibis.expr.operations.strings
     ops.RPad,
     ops.LPad,
+    # ibis.expr.operations.reductions
+    ops.BitAnd,
+    ops.BitOr,
+    ops.BitXor,
+    ops.GroupConcat,
 }
 
 operation_registry = {

diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -695,14 +695,9 @@ def mean_and_std(v):
             id='bit_and',
             marks=[
                 pytest.mark.notimpl(
-                    ["polars", "datafusion"],
+                    ["polars", "datafusion", "mssql"],
                     raises=com.OperationNotDefinedError,
                 ),
-                pytest.mark.notimpl(
-                    ["mssql"],
-                    raises=sa.exc.OperationalError,
-                    reason="'bit_and' is not a recognized built-in function name.",
-                ),
                 pytest.mark.notimpl(["druid"], strict=False, raises=AssertionError),
                 pytest.mark.notyet(
                     ["impala", "pyspark"], raises=com.OperationNotDefinedError
@@ -720,14 +715,9 @@ def mean_and_std(v):
             id='bit_or',
             marks=[
                 pytest.mark.notimpl(
-                    ["polars", "datafusion"],
+                    ["polars", "datafusion", "mssql"],
                     raises=com.OperationNotDefinedError,
                 ),
-                pytest.mark.notimpl(
-                    ["mssql"],
-                    raises=sa.exc.OperationalError,
-                    reason="'bit_or' is not a recognized built-in function name.",
-                ),
                 pytest.mark.notyet(
                     ["impala", "pyspark"], raises=com.OperationNotDefinedError
                 ),
@@ -744,14 +734,9 @@ def mean_and_std(v):
             id='bit_xor',
             marks=[
                 pytest.mark.notimpl(
-                    ["polars", "datafusion"],
+                    ["polars", "datafusion", "mssql"],
                     raises=com.OperationNotDefinedError,
                 ),
-                pytest.mark.notimpl(
-                    ["mssql"],
-                    raises=sa.exc.OperationalError,
-                    reason="'bit_xor' is not a recognized built-in function name.",
-                ),
                 pytest.mark.notyet(
                     ["impala", "pyspark"], raises=com.OperationNotDefinedError
                 ),
@@ -1206,19 +1191,14 @@ def test_approx_median(alltypes):
     ],
 )
 @mark.notimpl(
-    ["datafusion", "polars"],
+    ["datafusion", "polars", "mssql"],
     raises=com.OperationNotDefinedError,
 )
 @mark.notimpl(
     ["druid"],
     raises=sa.exc.ProgrammingError,
     reason="No match found for function signature group_concat(<CHARACTER>, <CHARACTER>)",
 )
-@mark.notimpl(
-    ["mssql"],
-    raises=sa.exc.OperationalError,
-    reason="'group_concat' is not a recognized built-in function name",
-)
 def test_group_concat(
     backend,
     alltypes,