feat(clickhouse): set default engine to native file

ibis-project · Apr 17, 2023 · 29815fa · 29815fa
1 parent 6fcac44
commit 29815fa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/ibis/backends/clickhouse/__init__.py b/ibis/backends/clickhouse/__init__.py
@@ -530,7 +530,7 @@ def create_table(
         temp: bool = False,
         overwrite: bool = False,
         # backend specific arguments
-        engine: str,
+        engine: str = "File(Native)",
         order_by: Iterable[str] | None = None,
         partition_by: Iterable[str] | None = None,
         sample_by: str | None = None,

diff --git a/ibis/backends/tests/test_client.py b/ibis/backends/tests/test_client.py
@@ -120,7 +120,7 @@ def test_sql(backend, con):
 }
 
 
-@mark.notimpl(["clickhouse", "datafusion", "polars", "druid"])
+@mark.notimpl(["datafusion", "polars", "druid"])
 def test_create_table_from_schema(con, new_schema, temp_table):
     new_table = con.create_table(temp_table, schema=new_schema)
     backend_mapping = backend_type_mapping.get(con.name, dict())
@@ -199,7 +199,7 @@ def test_rename_table(con, temp_table, new_schema):
         con.drop_table(temp_table, force=True)
 
 
-@mark.notimpl(["bigquery", "clickhouse", "datafusion", "polars", "druid"])
+@mark.notimpl(["bigquery", "datafusion", "polars", "druid"])
 @mark.never(["impala", "pyspark"], reason="No non-nullable datatypes")
 @mark.notyet(
     ["trino"], reason="trino doesn't support NOT NULL in its in-memory catalog"
@@ -747,7 +747,7 @@ def test_agg_memory_table(con):
         param(pd.DataFrame([("a", 1.0)], columns=["a", "b"]), id="pandas"),
     ],
 )
-@pytest.mark.notimpl(["clickhouse", "dask", "datafusion", "pandas", "polars", "druid"])
+@pytest.mark.notimpl(["dask", "datafusion", "pandas", "polars", "druid"])
 def test_create_from_in_memory_table(backend, con, t):
     if backend.name() == "snowflake":
         pytest.skip("snowflake is unreliable here")

diff --git a/ibis/backends/tests/test_map.py b/ibis/backends/tests/test_map.py
@@ -243,7 +243,6 @@ def tmptable(con):
         con.drop_table(name, force=True)
 
 
-@pytest.mark.notimpl(["clickhouse"], reason=".create_table not yet implemented in ibis")
 def test_map_create_table(con, tmptable):
     t = con.create_table(tmptable, schema=ibis.schema(dict(xyz="map<string, string>")))
     assert t.schema()["xyz"].is_map()