test(clickhouse): enable test_backend_specific_numerics test

ibis-project · Feb 5, 2023 · 2ac97a1 · 2ac97a1
1 parent 914c64c
commit 2ac97a1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/ibis/backends/tests/base.py b/ibis/backends/tests/base.py
@@ -3,7 +3,7 @@
 import abc
 import inspect
 from pathlib import Path
-from typing import Any, Callable, Mapping
+from typing import Any, Mapping
 
 import numpy as np
 import pandas as pd
@@ -152,14 +152,6 @@ def assert_frame_equal(
     def default_series_rename(series: pd.Series, name: str = 'tmp') -> pd.Series:
         return series.rename(name)
 
-    @staticmethod
-    def greatest(f: Callable[..., ir.Value], *args: ir.Value) -> ir.Value:
-        return f(*args)
-
-    @staticmethod
-    def least(f: Callable[..., ir.Value], *args: ir.Value) -> ir.Value:
-        return f(*args)
-
     @property
     def functional_alltypes(self) -> ir.Table:
         t = self.connection.table('functional_alltypes')

diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py
@@ -350,32 +350,32 @@ def test_complex_math_functions_columns(
             marks=pytest.mark.notimpl(["datafusion"]),
         ),
         param(
-            lambda be, t: be.least(ibis.least, t.bigint_col, t.int_col),
+            lambda be, t: ibis.least(t.bigint_col, t.int_col),
             lambda be, t: pd.Series(list(map(min, t.bigint_col, t.int_col))),
             id='least-all-columns',
             marks=pytest.mark.notimpl(["datafusion"]),
         ),
         param(
-            lambda be, t: be.least(ibis.least, t.bigint_col, t.int_col, -2),
+            lambda be, t: ibis.least(t.bigint_col, t.int_col, -2),
             lambda be, t: pd.Series(
                 list(map(min, t.bigint_col, t.int_col, [-2] * len(t)))
             ),
             id='least-scalar',
-            marks=pytest.mark.notimpl(["datafusion", "clickhouse"]),
+            marks=pytest.mark.notimpl(["datafusion"]),
         ),
         param(
-            lambda be, t: be.greatest(ibis.greatest, t.bigint_col, t.int_col),
+            lambda be, t: ibis.greatest(t.bigint_col, t.int_col),
             lambda be, t: pd.Series(list(map(max, t.bigint_col, t.int_col))),
             id='greatest-all-columns',
             marks=pytest.mark.notimpl(["datafusion"]),
         ),
         param(
-            lambda be, t: be.greatest(ibis.greatest, t.bigint_col, t.int_col, -2),
+            lambda be, t: ibis.greatest(t.bigint_col, t.int_col, -2),
             lambda be, t: pd.Series(
                 list(map(max, t.bigint_col, t.int_col, [-2] * len(t)))
             ),
             id='greatest-scalar',
-            marks=pytest.mark.notimpl(["datafusion", "clickhouse"]),
+            marks=pytest.mark.notimpl(["datafusion"]),
         ),
     ],
 )