feat(impala): implement Backend.rename_table

BREAKING CHANGE: `ImpalaTable.rename` is removed, use `Backend.rename_table` instead.

ibis/backends/impala/__init__.py

@@ -32,6 +32,7 @@
     DropDatabase,
     DropTable,
     DropView,
+    RenameTable,
     TruncateTable,
     fully_qualified_re,
     is_fully_qualified,
@@ -973,6 +974,19 @@ def truncate_table(self, name: str, database: str | None = None) -> None:
         statement = TruncateTable(name, database=database)
         self._safe_exec_sql(statement)
 
+    def rename_table(self, old_name: str, new_name: str) -> None:
+        """Rename an existing table.
+
+        Parameters
+        ----------
+        old_name
+            The old name of the table.
+        new_name
+            The new name of the table.
+        """
+        statement = RenameTable(old_name, new_name)
+        self._safe_exec_sql(statement)
+
     def drop_table_or_view(self, name, *, database=None, force=False):
         """Drop view or table."""
         try:

ibis/backends/impala/client.py

@@ -13,12 +13,7 @@
 from ibis import util
 from ibis.backends.base import Database
 from ibis.backends.base.sql.compiler import DDL, DML
-from ibis.backends.base.sql.ddl import (
-    AlterTable,
-    InsertSelect,
-    RenameTable,
-    fully_qualified_re,
-)
+from ibis.backends.base.sql.ddl import AlterTable, InsertSelect
 from ibis.backends.impala import ddl
 from ibis.backends.impala.compat import HS2Error, impyla
 
@@ -334,22 +329,6 @@ def load_data(self, path, overwrite=False, partition=None):
     def name(self) -> str:
         return self.op().name
 
-    def rename(self, new_name: str, database: str | None = None) -> ImpalaTable:
-        """Rename table inside Impala.
-
-        References to the old table are no longer valid.
-        """
-        m = fully_qualified_re.match(new_name)
-        if not m and database is None:
-            database = self._database
-        statement = RenameTable(
-            self.name, new_name, old_database=self._database, new_database=database
-        )
-        self._client._safe_exec_sql(statement)
-
-        op = self.op().copy(name=new_name, namespace=database)
-        return self.__class__(op)
-
     @property
     def is_partitioned(self):
         """True if the table is partitioned."""

ibis/backends/impala/tests/test_ddl.py

@@ -207,25 +207,6 @@ def test_drop_view(con, created_view):
     assert created_view not in con.list_tables()
 
 
-def test_rename_table(con, temp_database):
-    tmp_db = temp_database
-
-    orig_name = "tmp_rename_test"
-    con.create_table(orig_name, con.table("region"))
-    table = con.table(orig_name)
-
-    old_name = table.name
-
-    new_name = "rename_test"
-    renamed = table.rename(new_name, database=tmp_db)
-    renamed.execute()
-
-    t = con.table(new_name, database=tmp_db)
-    assert_equal(renamed, t)
-
-    assert table.name == old_name
-
-
 @pytest.fixture
 def path_uuid():
     return f"change-location-{util.guid()}"

ibis/backends/tests/test_client.py

@@ -253,7 +253,6 @@ def test_create_temporary_table_from_schema(tmpcon, new_schema):
         "datafusion",
         "druid",
         "duckdb",
-        "impala",
         "mssql",
         "mysql",
         "oracle",