Skip to content

Commit

Permalink
refactor(flink): use built-in DEGREES, RADIANS
Browse files Browse the repository at this point in the history
  • Loading branch information
@deepyaman @cpcloud
deepyaman authored and cpcloud committed Sep 8, 2023
1 parent f5a2aed commit 33518e9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ibis/backends/flink/registry.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from ibis.backends.base.sql.registry import (
fixed_arity,
helpers,
unary,
window,
)
from ibis.backends.base.sql.registry import (
Expand Down Expand Up @@ -192,6 +193,8 @@ def _window(translator: ExprTranslator, op: ops.Node) -> str:
ops.ExtractMinute: _extract_field("minute"), # equivalent to MINUTE(timestamp)
ops.ExtractSecond: _extract_field("second"), # equivalent to SECOND(timestamp)
ops.Literal: _literal,
ops.Degrees: unary("degrees"),
ops.Radians: unary("radians"),
ops.RegexSearch: fixed_arity("regexp", 2),
ops.TimestampFromUNIX: _timestamp_from_unix,
ops.Where: _filter,
Expand Down

1 comment on commit 33518e9

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: 33518e9 Previous: b37804a Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_builtins[str-medium] 449.9858861925205 iter/sec (stddev: 0.01341151559877759) 1605.1153838400996 iter/sec (stddev: 0.000004886304315266219) 3.57

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.