Skip to content

Commit

Permalink
fix(flink): add more test
Browse files Browse the repository at this point in the history
  • Loading branch information
zhenzhongxu authored and gforsyth committed Dec 6, 2023
1 parent 1b92b33 commit 33e1a31
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/ibis-docs-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ jobs:
- name: checkout
uses: actions/checkout@v4

- name: install pyflink
run: nix develop --ignore-environment --keep HOME -c pip install apache-flink

- name: run doctest
# keep HOME because duckdb (which we use for doctests) wants to use
# that for extensions
Expand All @@ -200,6 +203,21 @@ jobs:
- name: check that all frozen computations were done before push
run: git diff --exit-code --stat

- name: ls links 1
run: ls /home/runner/work/ibis/ibis/docs/_output/backends/

- name: ls links 2
run: ls /home/runner/work/ibis/ibis/docs/_output/

- name: ls links 3
run: ls /home/runner/work/ibis/ibis/docs/

- name: support
run: nix develop --ignore-environment -c python ./gen_matrix.py

- name: redirect links
run: python ./gen_redirects.py

- name: verify internal links
run: nix develop --ignore-environment '.#links' -c just checklinks --offline --no-progress

Expand Down
1 change: 1 addition & 0 deletions gen_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def main():
"docs", "backends", "raw_support_matrix.csv"
).open(mode="w") as f:
df.to_csv(f, index_label="FullOperation")
print(f"CSV output path: {f.name}") # noqa: T201


if __name__ == "__main__":
Expand Down
2 changes: 2 additions & 0 deletions ibis/backends/flink/tests/test_ddl.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ def test_force_recreate_in_mem_table(
tbl_properties=tbl_properties,
)
assert temp_table in con.list_tables()
assert temp_table in con.list_views()
if schema is not None:
assert new_table.schema() == schema

Expand All @@ -254,6 +255,7 @@ def test_force_recreate_in_mem_table(
overwrite=True,
)
assert temp_table in con.list_tables()
assert temp_table in con.list_views()
if schema is not None:
assert new_table.schema() == schema

Expand Down

0 comments on commit 33e1a31

Please sign in to comment.