refactor(datatypes): remove String parent type from JSON type

BREAKING CHANGE: `JSON` is no longer a subtype of `String`
ibis-project · Feb 6, 2023 · 34f3898 · 34f3898
1 parent d1e9d11
commit 34f3898
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ibis/expr/datatypes/cast.py b/ibis/expr/datatypes/cast.py
@@ -54,6 +54,8 @@ def can_cast_subtype(source: dt.DataType, target: dt.DataType, **kwargs) -> bool
 @castable.register(dt.Integer, (dt.Floating, dt.Decimal))
 @castable.register(dt.Floating, dt.Decimal)
 @castable.register((dt.Date, dt.Timestamp), (dt.Date, dt.Timestamp))
+@castable.register(dt.String, dt.JSON)
+@castable.register(dt.JSON, dt.String)
 def can_cast_any(source: dt.DataType, target: dt.DataType, **kwargs) -> bool:
     return True
 

diff --git a/ibis/expr/datatypes/core.py b/ibis/expr/datatypes/core.py
@@ -773,7 +773,7 @@ def _pretty_piece(self) -> str:
 
 
 @public
-class JSON(String):
+class JSON(Variadic):
     """JSON values."""
 
     scalar = ir.JSONScalar