Skip to content

Commit

Permalink
feat(api): include bad type in NotImplementedError (#8291)
Browse files Browse the repository at this point in the history
  • Loading branch information
NickCrews authored Feb 9, 2024
1 parent 4d89300 commit 36da06b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ibis/expr/operations/relations.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def _clean_join_predicates(left, right, predicates):
# resolve deferred expressions on the left table
pred = pred.resolve(left.to_expr())
elif not isinstance(pred, ir.Expr):
raise NotImplementedError
raise NotImplementedError(pred)

if not isinstance(pred, ir.BooleanValue):
raise com.ExpressionError("Join predicate must be a boolean expression")
Expand Down

0 comments on commit 36da06b

Please sign in to comment.