chore(clickhouse/flink/pyspark): handle zero-based indexing for ntile

ibis-project · Oct 13, 2023 · 3932785 · 3932785
1 parent ec96c6d
commit 3932785
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ibis/backends/flink/registry.py b/ibis/backends/flink/registry.py
@@ -196,7 +196,7 @@ def _window(translator: ExprTranslator, op: ops.Node) -> str:
     arg_formatted = translator.translate(func.__window_op__)
     result = f"{arg_formatted} {window_formatted}"
 
-    if isinstance(func, ops.RankBase):
+    if isinstance(func, (ops.RankBase, ops.NTile)):
         return f"({result} - 1)"
     else:
         return result

diff --git a/ibis/backends/pyspark/compiler.py b/ibis/backends/pyspark/compiler.py
@@ -1227,7 +1227,7 @@ def compile_window_function(t, op, **kwargs):
 
     result = t.translate(func, **kwargs, aggcontext=aggcontext).over(pyspark_window)
 
-    if isinstance(func, ops.RankBase):
+    if isinstance(func, (ops.RankBase, ops.NTile)):
         # result must be cast to long type for Rank / RowNumber
         return result.astype("long") - 1
     else: