fix(oracle): fix lstrip, rstrip, and strip

ibis/backends/sql/compilers/oracle.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import string
-
 import sqlglot as sg
 import sqlglot.expressions as sge
 import toolz
@@ -87,7 +85,6 @@ class OracleCompiler(SQLGlotCompiler):
         ops.LPad: "lpad",
         ops.RPad: "rpad",
         ops.StringAscii: "ascii",
-        ops.Strip: "trim",
         ops.Mode: "stats_mode",
     }
 
@@ -492,11 +489,11 @@ def visit_DateDelta(self, op, *, left, right, part):
             )
         return left - right
 
-    def visit_RStrip(self, op, *, arg):
-        return self.f.anon.rtrim(arg, string.whitespace)
-
-    def visit_LStrip(self, op, *, arg):
-        return self.f.anon.ltrim(arg, string.whitespace)
+    def visit_Strip(self, op, *, arg):
+        # Oracle's `TRIM` only accepts a single character to trim off, unlike
+        # Oracle's `RTRIM` and `LTRIM` which accept a set of characters to
+        # remove.
+        return self.visit_RStrip(op, arg=self.visit_LStrip(op, arg=arg))
 
 
 compiler = OracleCompiler()

ibis/backends/tests/test_string.py

@@ -1308,14 +1308,6 @@ def string_temp_table(backend, con):
                     TRIM(LEADING '\t\n\r ' FROM string_col)
                     """,
                 ),
-                pytest.mark.notimpl(
-                    ["oracle"],
-                    raises=AssertionError,
-                    reason="""
-                    Oracle `trim` doesn't accept characters to trim
-                    (unlike oracle `rtrim` and `ltrim`)
-                    """,
-                ),
                 pytest.mark.notimpl(
                     ["flink"],
                     raises=AssertionError,