feat(sqlalchemy): implement ilike

ibis-project · Mar 14, 2022 · 43996c0 · 43996c0
1 parent 527af3c
commit 43996c0
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 12 deletions.
diff --git a/ibis/backends/base/sql/alchemy/registry.py b/ibis/backends/base/sql/alchemy/registry.py
@@ -1,3 +1,4 @@
+import functools
 import operator
 from typing import Any, Dict
 
@@ -290,10 +291,10 @@ def unary(sa_func):
     return fixed_arity(sa_func, 1)
 
 
-def _string_like(t, expr):
-    arg, pattern, escape = expr.op().args
-    result = t.translate(arg).like(t.translate(pattern), escape=escape)
-    return result
+def _string_like(method_name, t, expr):
+    op = expr.op()
+    method = getattr(t.translate(op.arg), method_name)
+    return method(t.translate(op.pattern), escape=op.escape)
 
 
 def _startswith(t, expr):
@@ -482,7 +483,8 @@ def _sort_key(t, expr):
     ops.StringAscii: unary(sa.func.ascii),
     ops.StringLength: unary(sa.func.length),
     ops.StringReplace: fixed_arity(sa.func.replace, 3),
-    ops.StringSQLLike: _string_like,
+    ops.StringSQLLike: functools.partial(_string_like, "like"),
+    ops.StringSQLILike: functools.partial(_string_like, "ilike"),
     ops.StartsWith: _startswith,
     ops.EndsWith: _endswith,
     ops.StringConcat: varargs(sa.func.concat),

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -52,32 +52,46 @@ def test_string_col_is_unicode(backend, alltypes, df):
                 [
                     "clickhouse",
                     "datafusion",
-                    "duckdb",
                     "impala",
-                    "mysql",
-                    "postgres",
                     "pyspark",
-                    "sqlite",
                 ]
             ),
         ),
+        param(
+            lambda t: t.string_col.re_search(r'[[:digit:]]+'),
+            lambda t: t.string_col.str.contains(r'\d+'),
+            id='re_search_posix',
+            marks=pytest.mark.notimpl(["datafusion", "pyspark"]),
+        ),
+        param(
+            lambda t: t.string_col.re_extract(r'([[:digit:]]+)', 0),
+            lambda t: t.string_col.str.extract(r'(\d+)', expand=False),
+            id='re_extract_posix',
+            marks=pytest.mark.notimpl(["mysql", "pyspark"]),
+        ),
+        param(
+            lambda t: t.string_col.re_replace(r'[[:digit:]]+', 'a'),
+            lambda t: t.string_col.str.replace(r'\d+', 'a', regex=True),
+            id='re_replace_posix',
+            marks=pytest.mark.notimpl(['datafusion', "mysql", "pyspark"]),
+        ),
         param(
             lambda t: t.string_col.re_search(r'\d+'),
             lambda t: t.string_col.str.contains(r'\d+'),
             id='re_search',
-            marks=pytest.mark.notimpl(["datafusion"]),
+            marks=pytest.mark.notimpl(["impala", "datafusion"]),
         ),
         param(
             lambda t: t.string_col.re_extract(r'(\d+)', 0),
             lambda t: t.string_col.str.extract(r'(\d+)', expand=False),
             id='re_extract',
-            marks=pytest.mark.notimpl(["mysql"]),
+            marks=pytest.mark.notimpl(["impala", "mysql"]),
         ),
         param(
             lambda t: t.string_col.re_replace(r'\d+', 'a'),
             lambda t: t.string_col.str.replace(r'\d+', 'a', regex=True),
             id='re_replace',
-            marks=pytest.mark.notimpl(['datafusion', "mysql"]),
+            marks=pytest.mark.notimpl(["impala", "datafusion", "mysql"]),
         ),
         param(
             lambda t: t.string_col.repeat(2),