Skip to content

Commit

Permalink
ci(snowflake): allow concurrent python version tests to run
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Sep 24, 2023
1 parent 0908253 commit 43ff6e3
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions .github/workflows/ibis-backends-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
# only a single bigquery or snowflake run at a time, otherwise test data is
# clobbered by concurrent runs
concurrency:
group: ${{ matrix.backend.name }}
group: ${{ matrix.backend.name }}-${{ matrix.python-version }}
cancel-in-progress: false
runs-on: ubuntu-latest
strategy:
Expand All @@ -42,13 +42,18 @@ jobs:
backend:
- name: bigquery
title: BigQuery
deps: []
- name: snowflake
title: Snowflake
- name: snowflake
title: Snowflake with nanoarrow
deps:
- snowflake-connector-python[pandas]@3.3.0b1
- --optional
deps: []
include:
- python-version: "3.10"
backend:
name: snowflake
title: Snowflake with nanoarrow
deps:
- snowflake-connector-python[pandas]@3.3.0b1
- --optional
steps:
- name: checkout
uses: actions/checkout@v4
Expand All @@ -60,7 +65,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- uses: syphar/restore-virtualenv@v1
if: matrix.backend.deps == null
if: toJSON(matrix.backend.deps) == '[]'
with:
requirement_files: poetry.lock
custom_cache_key_element: ${{ matrix.backend.name }}-${{ steps.install_python.outputs.python-version }}
Expand All @@ -69,11 +74,11 @@ jobs:
run: python -m pip install --upgrade pip 'poetry==1.6.1'

- name: install a prerelease version of `snowflake-connector-python`
if: matrix.backend.deps != null
if: toJSON(matrix.backend.deps) != '[]'
run: poetry add ${{ join(matrix.backend.deps, ' ') }}

- uses: syphar/restore-pip-download-cache@v1
if: matrix.backend.deps == null
if: toJSON(matrix.backend.deps) == '[]'
with:
requirement_files: poetry.lock
custom_cache_key_element: ${{ matrix.backend.name }}-${{ steps.install_python.outputs.python-version }}
Expand Down

1 comment on commit 43ff6e3

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: 43ff6e3 Previous: b37804a Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_compile_with_drops[bigquery] 31.769844971036974 iter/sec (stddev: 0.018469742781936842) 130.02477424437095 iter/sec (stddev: 0.000247510166318326) 4.09
ibis/tests/benchmarks/test_benchmarks.py::test_compile[large-bigquery] 23.091710564297163 iter/sec (stddev: 0.025971155996910997) 146.4406797920701 iter/sec (stddev: 0.00006932716190392247) 6.34
ibis/tests/benchmarks/test_benchmarks.py::test_compile[medium-bigquery] 61.91757798395937 iter/sec (stddev: 0.0008913682796410538) 603.5295570002766 iter/sec (stddev: 0.000035398257191080955) 9.75
ibis/tests/benchmarks/test_benchmarks.py::test_compile[small-bigquery] 1426.9498897894177 iter/sec (stddev: 0.00008182601059569951) 10602.847663506958 iter/sec (stddev: 0.00005834248372791223) 7.43

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.