Skip to content

Commit

Permalink
feat(snowflake): implement array sort
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored and kszucs committed Aug 5, 2023
1 parent 4791cb4 commit 465fae1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/snowflake/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ def _map_get(t, op):
ops.Median: reduction(sa.func.median),
ops.TableColumn: _table_column,
ops.Levenshtein: fixed_arity(sa.func.editdistance, 2),
ops.ArraySort: fixed_arity(sa.func.array_sort, 1),
}
)

Expand All @@ -471,7 +472,6 @@ def _map_get(t, op):
# ibis.expr.operations.array
ops.ArrayRemove,
ops.ArrayRepeat,
ops.ArraySort,
# ibis.expr.operations.reductions
ops.MultiQuantile,
# ibis.expr.operations.strings
Expand Down
11 changes: 1 addition & 10 deletions ibis/backends/tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -648,16 +648,7 @@ def test_array_unique(backend, con):


@pytest.mark.notimpl(
[
"bigquery",
"dask",
"datafusion",
"impala",
"mssql",
"pandas",
"polars",
"snowflake",
],
["bigquery", "dask", "datafusion", "impala", "mssql", "pandas", "polars"],
raises=com.OperationNotDefinedError,
)
@pytest.mark.notimpl(
Expand Down

0 comments on commit 465fae1

Please sign in to comment.