Skip to content

Commit

Permalink
feat(oracle): support group_concat operator
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored and jcrist committed Jul 31, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent a63cee9 commit 47d97ea
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 6 additions & 0 deletions ibis/backends/sql/compilers/oracle.py
Original file line number Diff line number Diff line change
@@ -446,3 +446,9 @@ def visit_StringConcat(self, op, *, arg):

def visit_ExtractIsoYear(self, op, *, arg):
return self.cast(self.f.to_char(arg, "IYYY"), op.dtype)

def visit_GroupConcat(self, op, *, arg, where, sep):
if where is not None:
arg = self.if_(where, arg)

return self.f.listagg(arg, sep)
5 changes: 0 additions & 5 deletions ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
@@ -1234,11 +1234,6 @@ def test_date_quantile(alltypes):
],
)
@pytest.mark.notimpl(["datafusion", "polars"], raises=com.OperationNotDefinedError)
@pytest.mark.notyet(
["oracle"],
raises=OracleDatabaseError,
reason="ORA-00904: 'GROUP_CONCAT': invalid identifier",
)
@pytest.mark.notimpl(["exasol"], raises=ExaQueryError)
@pytest.mark.notyet(["flink"], raises=Py4JJavaError)
def test_group_concat(

0 comments on commit 47d97ea

Please sign in to comment.