refactor(sqlglot): clean up explode usage

ibis-project · Feb 12, 2024 · 4d99314 · 4d99314
1 parent 776079c
commit 4d99314
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/ibis/backends/base/sqlglot/compiler.py b/ibis/backends/base/sqlglot/compiler.py
@@ -1213,10 +1213,6 @@ def visit_SQLStringView(self, op, *, query: str, name: str, child):
     def visit_SQLQueryResult(self, op, *, query, schema, source):
         return sg.parse_one(query, read=self.dialect).subquery()
 
-    @visit_node.register(ops.Unnest)
-    def visit_Unnest(self, op, *, arg):
-        return sge.Explode(this=arg)
-
     @visit_node.register(ops.JoinTable)
     def visit_JoinTable(self, op, *, parent, index):
         return parent

diff --git a/ibis/backends/postgres/compiler.py b/ibis/backends/postgres/compiler.py
@@ -233,9 +233,7 @@ def visit_ArrayRepeat(self, op, *, arg, times):
     @visit_node.register(ops.ArrayDistinct)
     def visit_ArrayDistinct(self, op, *, arg):
         return self.if_(
-            arg.is_(NULL),
-            NULL,
-            self.f.array(sg.select(sge.Explode(this=arg)).distinct()),
+            arg.is_(NULL), NULL, self.f.array(sg.select(self.f.explode(arg)).distinct())
         )
 
     @visit_node.register(ops.ArrayUnion)
@@ -248,7 +246,7 @@ def visit_ArrayUnion(self, op, *, left, right):
     def visit_ArrayIntersect(self, op, *, left, right):
         return self.f.anon.array(
             sg.intersect(
-                sg.select(sge.Explode(this=left)), sg.select(sge.Explode(this=right))
+                sg.select(self.f.explode(left)), sg.select(self.f.explode(right))
             )
         )
 

diff --git a/ibis/backends/snowflake/compiler.py b/ibis/backends/snowflake/compiler.py
@@ -495,7 +495,7 @@ def visit_Unnest(self, op, *, arg):
         split = self.f.split(
             self.f.array_to_string(self.f.nullif(arg, self.f.array()), sep), sep
         )
-        expr = self.f.nullif(sge.Explode(this=split), "")
+        expr = self.f.nullif(self.f.explode(split), "")
         return self.cast(expr, op.dtype)
 
     @visit_node.register(ops.Quantile)