feat(bigquery): implement ops.Degrees, ops.Radians

ibis-project · Jan 4, 2023 · 5119b93 · 5119b93
1 parent 5495d6d
commit 5119b93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ibis/backends/bigquery/registry.py b/ibis/backends/bigquery/registry.py
@@ -546,6 +546,8 @@ def _clip(t, op):
     ops.Modulus: fixed_arity("MOD", 2),
     ops.Sign: unary("SIGN"),
     ops.Clip: _clip,
+    ops.Degrees: lambda t, op: f"(180 * {t.translate(op.arg)} / ACOS(-1))",
+    ops.Radians: lambda t, op: f"(ACOS(-1) * {t.translate(op.arg)} / 180)",
     # Temporal functions
     ops.Date: unary("DATE"),
     ops.DateFromYMD: fixed_arity("DATE", 3),

diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py
@@ -163,13 +163,13 @@ def test_isnan_isinf(
             L(5.556).radians(),
             math.radians(5.556),
             id='radians',
-            marks=pytest.mark.notimpl(["bigquery", "datafusion", "impala"]),
+            marks=pytest.mark.notimpl(["datafusion", "impala"]),
         ),
         param(
             L(5.556).degrees(),
             math.degrees(5.556),
             id='degrees',
-            marks=pytest.mark.notimpl(["bigquery", "datafusion", "impala"]),
+            marks=pytest.mark.notimpl(["datafusion", "impala"]),
         ),
         param(L(11) % 3, 11 % 3, id='mod'),
     ],