feat(trino): implement bitwise agg support

ibis-project · Dec 21, 2022 · 5288b35 · 5288b35
1 parent 7c41566
commit 5288b35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -450,7 +450,7 @@ def mean_and_std(v):
             id='bit_and',
             marks=[
                 pytest.mark.notimpl(
-                    ["dask", "snowflake", "polars", "datafusion", "mssql", "trino"]
+                    ["dask", "snowflake", "polars", "datafusion", "mssql"]
                 ),
                 pytest.mark.notyet(["impala", "pyspark"]),
             ],
@@ -461,7 +461,7 @@ def mean_and_std(v):
             id='bit_or',
             marks=[
                 pytest.mark.notimpl(
-                    ["dask", "snowflake", "polars", "datafusion", "mssql", "trino"]
+                    ["dask", "snowflake", "polars", "datafusion", "mssql"]
                 ),
                 pytest.mark.notyet(["impala", "pyspark"]),
             ],

diff --git a/ibis/backends/trino/registry.py b/ibis/backends/trino/registry.py
@@ -43,6 +43,8 @@ def _json_get_item(t, op):
         ops.Covariance: _covar,
         ops.ExtractMillisecond: unary(sa.func.millisecond),
         ops.Arbitrary: _arbitrary,
+        ops.BitAnd: reduction(sa.func.bitwise_and_agg),
+        ops.BitOr: reduction(sa.func.bitwise_or_agg),
         ops.JSONGetItem: _json_get_item,
     }
 )