fix(druid): ensure that string types are translated to VARCHAR

ibis-project · Sep 12, 2023 · 56e6ffc · 56e6ffc
1 parent 1d1f7bd
commit 56e6ffc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/ibis/backends/druid/datatypes.py b/ibis/backends/druid/datatypes.py
@@ -54,6 +54,11 @@ def _smallint(element, compiler, **kw):
     return "SMALLINT"
 
 
+@compiles(DruidString, "druid")
+def _string(element, compiler, **kw):
+    return "VARCHAR"
+
+
 class DruidType(AlchemyType):
     dialect = "hive"
 

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -1059,7 +1059,6 @@ def test_levenshtein(con, right):
     reason="doesn't allow boolean expressions in select statements",
     raises=sa.exc.OperationalError,
 )
-@pytest.mark.notyet(["druid"], raises=sa.exc.ProgrammingError)
 @pytest.mark.broken(
     ["oracle"],
     reason="sqlalchemy converts True to 1, which cannot be used in CASE WHEN statement",