feat(datafusion): implement ops.Pi, ops.E

ibis-project · Feb 16, 2023 · 5a74cb4 · 5a74cb4
1 parent 4193867
commit 5a74cb4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/ibis/backends/datafusion/compiler.py b/ibis/backends/datafusion/compiler.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import functools
+import math
 import operator
 
 import datafusion as df
@@ -423,6 +424,16 @@ def cot(op):
     return df.lit(1.0) / df.functions.tan(x)
 
 
+@translate.register(ops.Pi)
+def pi(_):
+    return df.lit(math.pi)
+
+
+@translate.register(ops.E)
+def e(_):
+    return df.lit(math.e)
+
+
 @translate.register(ops.ElementWiseVectorizedUDF)
 def elementwise_udf(op):
     udf = df.udf(

diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py
@@ -1248,7 +1248,6 @@ def test_histogram(con, alltypes):
     assert len(results.value_counts()) == n
 
 
-@pytest.mark.notimpl(["datafusion"], raises=com.OperationNotDefinedError)
 @pytest.mark.parametrize("const", ["e", "pi"])
 def test_constants(con, const):
     expr = getattr(ibis, const)