fix(duckdb): render dates, times, timestamps and none literals correctly

ibis-project · Dec 12, 2023 · 5d8866a · 5d8866a
1 parent 66fbad6
commit 5d8866a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ibis/backends/duckdb/registry.py b/ibis/backends/duckdb/registry.py
@@ -176,7 +176,9 @@ def _literal(t, op):
     value = op.value
 
     if value is None:
-        return sa.null()
+        return (
+            sa.null() if dtype.is_null() else sa.cast(sa.null(), t.get_sqla_type(dtype))
+        )
 
     sqla_type = t.get_sqla_type(dtype)
 
@@ -209,7 +211,7 @@ def _literal(t, op):
             sa.func.list_value(*value.keys()), sa.func.list_value(*value.values())
         )
     elif dtype.is_timestamp():
-        return sa.cast(value.isoformat(), t.get_sqla_type(dtype))
+        return sa.cast(sa.literal(value.isoformat()), t.get_sqla_type(dtype))
     elif dtype.is_date():
         return sa.func.make_date(value.year, value.month, value.day)
     elif dtype.is_time():