fix(sqlite): truncate week to previous week not following

ibis-project · Oct 31, 2023 · 6239794 · 6239794
1 parent f6b2722
commit 6239794
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/ibis/backends/sqlite/registry.py b/ibis/backends/sqlite/registry.py
@@ -92,14 +92,14 @@ def _extract_quarter(t, op):
 
 
 _truncate_modifiers = {
-    DateUnit.DAY: "start of day",
-    DateUnit.WEEK: "weekday 1",
-    DateUnit.MONTH: "start of month",
-    DateUnit.YEAR: "start of year",
-    IntervalUnit.DAY: "start of day",
-    IntervalUnit.WEEK: "weekday 1",
-    IntervalUnit.MONTH: "start of month",
-    IntervalUnit.YEAR: "start of year",
+    DateUnit.DAY: ("start of day",),
+    DateUnit.WEEK: ("weekday 0", "-6 days"),
+    DateUnit.MONTH: ("start of month",),
+    DateUnit.YEAR: ("start of year",),
+    IntervalUnit.DAY: ("start of day",),
+    IntervalUnit.WEEK: ("weekday 1",),
+    IntervalUnit.MONTH: ("start of month",),
+    IntervalUnit.YEAR: ("start of year",),
 }
 
 
@@ -112,7 +112,7 @@ def translator(t, op):
             raise com.UnsupportedOperationError(
                 f"Unsupported truncate unit {op.unit!r}"
             )
-        return func(sa_arg, modifier)
+        return func(sa_arg, *modifier)
 
     return translator
 

diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -537,7 +537,7 @@ def test_timestamp_truncate(backend, alltypes, df, unit):
                     raises=com.UnsupportedOperationError,
                     reason="Unsupported truncate unit W",
                 ),
-                pytest.mark.broken(["impala", "sqlite"], raises=AssertionError),
+                pytest.mark.broken(["impala"], raises=AssertionError),
             ],
         ),
     ],