feat(trino): implement ops.StringSplit

ibis-project · Dec 24, 2022 · 62d79a6 · 62d79a6
1 parent 691b39c
commit 62d79a6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/ibis/backends/tests/test_param.py b/ibis/backends/tests/test_param.py
@@ -165,7 +165,17 @@ def test_scalar_param(alltypes, df, value, dtype, col):
 @pytest.mark.parametrize(
     ("value", "dtype"),
     [
-        param("2009-01-20", "date", id="string_date"),
+        param(
+            "2009-01-20",
+            "date",
+            id="string_date",
+            marks=[
+                pytest.mark.broken(
+                    ["trino"],
+                    reason="generates incorrect SQL for date string values",
+                )
+            ],
+        ),
         param(datetime.date(2009, 1, 20), "date", id="date_date"),
         param(datetime.datetime(2009, 1, 20), "date", id="datetime_date"),
     ],
@@ -181,7 +191,6 @@ def test_scalar_param(alltypes, df, value, dtype, col):
         "impala",
         "pyspark",
         "mssql",
-        "trino",
     ]
 )
 def test_scalar_param_date(backend, alltypes, value, dtype):

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -360,7 +360,6 @@ def test_string_col_is_unicode(alltypes, df):
                     "sqlite",
                     "snowflake",
                     "mssql",
-                    "trino",
                 ]
             ),
         ),

diff --git a/ibis/backends/trino/registry.py b/ibis/backends/trino/registry.py
@@ -101,6 +101,7 @@ def _string_right(t, op):
         ops.Translate: fixed_arity(sa.func.translate, 3),
         ops.Capitalize: _capitalize,
         ops.StrRight: _string_right,
+        ops.StringSplit: fixed_arity(sa.func.split, 2),
         ops.Repeat: fixed_arity(
             lambda value, count: sa.func.array_join(sa.func.repeat(value, count), ''), 2
         ),