fix(sqlglot): ensure that sample works with multiple sqlglot versions

ibis/backends/sql/compilers/base.py

@@ -1637,6 +1637,16 @@ def add_query_to_expr(self, *, name: str, table: ir.Table, query: str) -> str:
         # generate the SQL string
         return parsed.sql(dialect)
 
+    def _make_sample_backwards_compatible(self, *, sample, parent):
+        # sample was changed to be owned by the table being sampled in 25.17.0
+        #
+        # this is a small workaround for backwards compatibility
+        if "this" in sample.__class__.arg_types:
+            sample.args["this"] = parent
+        else:
+            parent.args["sample"] = sample
+        return sg.select(STAR).from_(parent)
+
 
 # `__init_subclass__` is uncalled for subclasses - we manually call it here to
 # autogenerate the base class implementations as well.

ibis/backends/sql/compilers/duckdb.py

@@ -168,12 +168,12 @@ def visit_Sample(
         self, op, *, parent, fraction: float, method: str, seed: int | None, **_
     ):
         sample = sge.TableSample(
-            this=parent,
             method="bernoulli" if method == "row" else "system",
             percent=sge.convert(fraction * 100.0),
             seed=None if seed is None else sge.convert(seed),
         )
-        return sg.select(STAR).from_(sample)
+
+        return self._make_sample_backwards_compatible(sample=sample, parent=parent)
 
     def visit_ArraySlice(self, op, *, arg, start, stop):
         arg_length = self.f.len(arg)

ibis/backends/sql/compilers/pyspark.py

@@ -334,11 +334,8 @@ def visit_Sample(
             raise com.UnsupportedOperationError(
                 "PySpark backend does not support sampling with seed."
             )
-        sample = sge.TableSample(
-            this=parent,
-            percent=sge.convert(fraction * 100.0),
-        )
-        return sg.select(STAR).from_(sample)
+        sample = sge.TableSample(percent=sge.convert(fraction * 100.0))
+        return self._make_sample_backwards_compatible(sample=sample, parent=parent)
 
     def visit_WindowBoundary(self, op, *, value, preceding):
         if isinstance(op.value, ops.Literal) and op.value.value == 0:

ibis/backends/sql/compilers/snowflake.py

@@ -761,12 +761,11 @@ def visit_Sample(
         self, op, *, parent, fraction: float, method: str, seed: int | None, **_
     ):
         sample = sge.TableSample(
-            this=parent,
             method="bernoulli" if method == "row" else "system",
             percent=sge.convert(fraction * 100.0),
             seed=None if seed is None else sge.convert(seed),
         )
-        return sg.select(STAR).from_(sample)
+        return self._make_sample_backwards_compatible(sample=sample, parent=parent)
 
     def visit_ArrayMap(self, op, *, arg, param, body):
         return self.f.transform(arg, sge.Lambda(this=body, expressions=[param]))

ibis/backends/sql/compilers/trino.py

@@ -108,17 +108,16 @@ def _minimize_spec(start, end, spec):
     def visit_Sample(
         self, op, *, parent, fraction: float, method: str, seed: int | None, **_
     ):
-        if op.seed is not None:
+        if seed is not None:
             raise com.UnsupportedOperationError(
                 "`Table.sample` with a random seed is unsupported"
             )
         sample = sge.TableSample(
-            this=parent,
             method="bernoulli" if method == "row" else "system",
             percent=sge.convert(fraction * 100.0),
             seed=None if seed is None else sge.convert(seed),
         )
-        return sg.select(STAR).from_(sample)
+        return self._make_sample_backwards_compatible(sample=sample, parent=parent)
 
     def visit_Correlation(self, op, *, left, right, how, where):
         if how == "sample":