fix(api): support filter on literal followed by aggregate

ibis/expr/analysis.py

@@ -620,7 +620,8 @@ def shares_some_roots(exprs, parents):
     # unique table dependencies of exprs and parents
     exprs_deps = set(g.traverse(_find_projections, exprs))
     parents_deps = set(g.traverse(_find_projections, parents))
-    return bool(exprs_deps & parents_deps)
+    # Also return True if exprs has no roots (e.g. literal-only expressions)
+    return bool(exprs_deps & parents_deps) or not exprs_deps
 
 
 def flatten_predicate(node):

ibis/tests/expr/test_table.py

@@ -712,6 +712,12 @@ def test_filter_aggregate_pushdown_predicate(table):
     assert_equal(filtered, expected)
 
 
+def test_filter_on_literal_then_aggregate(table):
+    # Mostly just a smoketest, this used to error on construction
+    expr = table.filter(ibis.literal(True)).agg(lambda t: t.a.sum().name("total"))
+    assert expr.columns == ["total"]
+
+
 @pytest.mark.parametrize(
     "case_fn",
     [