Skip to content

Commit

Permalink
test(backends): fix impala tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Aug 26, 2024
1 parent 7393c31 commit 6d12c19
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/impala/tests/test_ddl.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,5 +332,5 @@ def test_varchar_char_support(temp_char_table):


def test_access_kudu_table(kudu_table):
assert kudu_table.columns == ["a"]
assert kudu_table.columns == ("a",)

Check warning on line 335 in ibis/backends/impala/tests/test_ddl.py

View check run for this annotation

Codecov / codecov/patch

ibis/backends/impala/tests/test_ddl.py#L335

Added line #L335 was not covered by tests
assert kudu_table["a"].type() == dt.string
2 changes: 1 addition & 1 deletion ibis/backends/impala/tests/test_exprs.py
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ def test_where_with_timestamp(snapshot):

def test_filter_with_analytic(snapshot):
x = ibis.table(ibis.schema([("col", "int32")]), "x")
with_filter_col = x[x.columns + [ibis.null().name("filter")]]
with_filter_col = x[[*x.columns, ibis.null().name("filter")]]

Check warning on line 668 in ibis/backends/impala/tests/test_exprs.py

View check run for this annotation

Codecov / codecov/patch

ibis/backends/impala/tests/test_exprs.py#L668

Added line #L668 was not covered by tests
filtered = with_filter_col[with_filter_col["filter"].isnull()]
subquery = filtered[filtered.columns]

Expand Down

0 comments on commit 6d12c19

Please sign in to comment.