fix(clickhouse): fix position call

ibis-project · Jan 24, 2023 · 702de5d · 702de5d
1 parent cb7f0a3
commit 702de5d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/ibis/backends/clickhouse/compiler/values.py b/ibis/backends/clickhouse/compiler/values.py
@@ -277,7 +277,7 @@ def _string_find(op, **kw):
 
     arg = translate_val(op.arg, **kw)
     substr = translate_val(op.substr, **kw)
-    return f"position({substr} IN {arg}) - 1"
+    return f"locate({arg}, {substr}) - 1"
 
 
 @translate_val.register(ops.RegexExtract)
@@ -747,7 +747,7 @@ def _scalar_param(op, params: Mapping[ops.Node, Any], **kw):
 def _string_contains(op, **kw):
     haystack = translate_val(op.haystack, **kw)
     needle = translate_val(op.needle, **kw)
-    return f"position({needle} IN {haystack}) > 0"
+    return f"locate({haystack}, {needle}) > 0"
 
 
 def contains(op_string: Literal["IN", "NOT IN"]) -> str:

diff --git a/ibis/backends/clickhouse/tests/snapshots/test_functions/test_string_column_find/out1.sql b/ibis/backends/clickhouse/tests/snapshots/test_functions/test_string_column_find/out1.sql
@@ -1 +1 @@
-position('a' IN string_col) - 1
+locate(string_col, 'a') - 1
diff --git a/ibis/backends/clickhouse/tests/snapshots/test_functions/test_string_column_find/out2.sql b/ibis/backends/clickhouse/tests/snapshots/test_functions/test_string_column_find/out2.sql
@@ -1 +1 @@
-position(string_col IN string_col) - 1
+locate(string_col, string_col) - 1
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		position('a' IN string_col) - 1
		locate(string_col, 'a') - 1
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		position(string_col IN string_col) - 1
		locate(string_col, string_col) - 1