Skip to content

Commit

Permalink
refactor(ir): remove ibis.expr.streaming
Browse files Browse the repository at this point in the history
  • Loading branch information
kszucs authored and jcrist committed Oct 10, 2023
1 parent 349f475 commit 70df318
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/flink/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from pyflink.table import TableEnvironment
from pyflink.table.table_result import TableResult

from ibis.expr.streaming import Watermark
from ibis.api import Watermark


class Backend(BaseBackend, CanCreateDatabase):
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/flink/ddl.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from ibis.backends.base.sql.registry import quote_identifier, type_to_sql_string

if TYPE_CHECKING:
from ibis.expr.streaming import Watermark
from ibis.api import Watermark


def format_schema(schema):
Expand Down
7 changes: 6 additions & 1 deletion ibis/expr/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
from ibis.backends.base import BaseBackend, connect
from ibis.common.dispatch import lazy_singledispatch
from ibis.common.exceptions import IbisInputError
from ibis.common.grounds import Concrete
from ibis.common.temporal import normalize_datetime, normalize_timezone
from ibis.expr.decompile import decompile
from ibis.expr.deferred import Deferred, deferrable
from ibis.expr.schema import Schema
from ibis.expr.sql import parse_sql, show_sql, to_sql
from ibis.expr.streaming import Watermark
from ibis.expr.types import (
DateValue,
Expr,
Expand Down Expand Up @@ -1745,6 +1745,11 @@ def difference(table: ir.Table, *rest: ir.Table, distinct: bool = True) -> ir.Ta
return table.difference(*rest, distinct=distinct) if rest else table


class Watermark(Concrete):
time_col: str
allowed_delay: ir.IntervalScalar


def watermark(time_col: str, allowed_delay: ir.IntervalScalar) -> Watermark:
"""Return a watermark object.
Expand Down
9 changes: 0 additions & 9 deletions ibis/expr/streaming.py

This file was deleted.

0 comments on commit 70df318

Please sign in to comment.