fix(trino): generate first_value/lasts_value instead of arbitrary

ibis-project · Mar 12, 2024 · 710f8ac · 710f8ac
1 parent 4bdc040
commit 710f8ac
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/ibis/backends/sql/dialects.py b/ibis/backends/sql/dialects.py
@@ -294,5 +294,7 @@ def make_cross_joins_explicit(node):
 Trino.Generator.TRANSFORMS |= {
     sge.BitwiseLeftShift: rename_func("bitwise_left_shift"),
     sge.BitwiseRightShift: rename_func("bitwise_right_shift"),
+    sge.FirstValue: rename_func("first_value"),
     sge.Join: transforms.preprocess([make_cross_joins_explicit]),
+    sge.LastValue: rename_func("last_value"),
 }