refactor(flink): use FILTER syntax when counting

ibis-project · Oct 9, 2023 · 815c12f · 815c12f
1 parent 2cbca74
commit 815c12f
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/ibis/backends/flink/registry.py b/ibis/backends/flink/registry.py
@@ -18,13 +18,12 @@
 
 
 def _count_star(translator: ExprTranslator, op: ops.Node) -> str:
-    # TODO(deepyaman): Use `FILTER` syntax; see note on `_filter` below.
     if (where := op.where) is not None:
-        condition = f"CASE WHEN {translator.translate(where)} THEN 1 END"
+        condition = f" FILTER (WHERE {translator.translate(where)})"
     else:
-        condition = "*"
+        condition = ""
 
-    return f"COUNT({condition})"
+    return f"COUNT(*){condition}"
 
 
 def _date(translator: ExprTranslator, op: ops.Node) -> str: