Skip to content

Commit

Permalink
fix(flink): correct translation of ops.IfNull op
Browse files Browse the repository at this point in the history
  • Loading branch information
@deepyaman @cpcloud
deepyaman authored and cpcloud committed Sep 19, 2023
1 parent 36270a9 commit 85de81c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ibis/backends/flink/registry.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ def _floor_divide(translator: ExprTranslator, op: ops.Node) -> str:
operation_registry.update(
{
# Unary operations
ops.IfNull: fixed_arity("ifnull", 2),
ops.NullIfZero: _nullifzero,
ops.RandomScalar: lambda *_: "rand()",
ops.Degrees: unary("degrees"),
Expand Down

1 comment on commit 85de81c

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: 85de81c Previous: b37804a Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_compile_with_drops[sqlite] 14.979051927881892 iter/sec (stddev: 0.5021330903634733) 105.46743867667972 iter/sec (stddev: 0.0008648224287252402) 7.04

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.