chore: remove unnecessary requires_within_group AggGen property

ibis/backends/sql/compilers/base.py

@@ -82,18 +82,13 @@ def __getattr__(self, name: str) -> Callable:
 
         __getitem__ = __getattr__
 
-    __slots__ = ("supports_filter", "supports_order_by", "requires_within_group")
+    __slots__ = ("supports_filter", "supports_order_by")
 
     def __init__(
-        self,
-        *,
-        supports_filter: bool = False,
-        supports_order_by: bool = False,
-        requires_within_group: bool = False,
+        self, *, supports_filter: bool = False, supports_order_by: bool = False
     ):
         self.supports_filter = supports_filter
         self.supports_order_by = supports_order_by
-        self.requires_within_group = requires_within_group
 
     def __get__(self, instance, owner=None):
         if instance is None:
@@ -137,13 +132,8 @@ def aggregate(
             args = tuple(compiler.if_(where, arg, NULL) for arg in args)
 
         if order_by and self.supports_order_by:
-            if self.requires_within_group:
-                out = sge.WithinGroup(
-                    this=func(*args), expression=sge.Order(expressions=order_by)
-                )
-            else:
-                *rest, last = args
-                out = func(*rest, sge.Order(this=last, expressions=order_by))
+            *rest, last = args
+            out = func(*rest, sge.Order(this=last, expressions=order_by))
         else:
             out = func(*args)
 

ibis/backends/sql/compilers/mssql.py

@@ -53,7 +53,7 @@ def rewrite_rows_range_order_by_window(_, **kwargs):
 class MSSQLCompiler(SQLGlotCompiler):
     __slots__ = ()
 
-    agg = AggGen(supports_order_by=True, requires_within_group=True)
+    agg = AggGen(supports_order_by=True)
 
     dialect = MSSQL
     type_mapper = MSSQLType

ibis/backends/sql/compilers/oracle.py

@@ -23,7 +23,7 @@
 class OracleCompiler(SQLGlotCompiler):
     __slots__ = ()
 
-    agg = AggGen(supports_order_by=True, requires_within_group=True)
+    agg = AggGen(supports_order_by=True)
 
     dialect = Oracle
     type_mapper = OracleType

ibis/backends/sql/compilers/snowflake.py

@@ -40,7 +40,7 @@ class SnowflakeCompiler(SQLGlotCompiler):
     type_mapper = SnowflakeType
     no_limit_value = NULL
 
-    agg = AggGen(supports_order_by=True, requires_within_group=True)
+    agg = AggGen(supports_order_by=True)
 
     rewrites = (
         exclude_unsupported_window_frame_from_row_number,