Skip to content

Commit

Permalink
feat(pyspark): topk support
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed May 6, 2022
1 parent 2c33e46 commit 9344591
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ def test_topk_op(backend, alltypes, df, result_fn, expected_fn):
)
],
)
@mark.notimpl(["datafusion", "pandas", "dask", "pyspark"])
@mark.notimpl(["datafusion", "pandas", "dask"])
def test_topk_filter_op(alltypes, df, result_fn, expected_fn):
# TopK expression will order rows by "count" but each backend
# can have different result for that.
Expand Down
3 changes: 1 addition & 2 deletions ibis/tests/expr/test_analytics.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import pytest

import ibis
import ibis.expr.operations as ops
import ibis.expr.types as ir
from ibis.tests.expr.mocks import MockBackend
from ibis.tests.util import assert_equal
Expand Down Expand Up @@ -111,7 +110,7 @@ def test_topk_analysis_bug(airlines):

filtered = t.filter([delay_filter])

assert delay_filter._to_semi_join(t).equals(filtered)
assert delay_filter._to_semi_join(t)[t].equals(filtered)


def test_topk_function_late_bind(airlines):
Expand Down

0 comments on commit 9344591

Please sign in to comment.