fix(bigquery): generate the correct temporal literal type based on th…

…e presence of timezone information

ibis/backends/bigquery/registry.py

@@ -362,7 +362,8 @@ def _literal(t, op):
             value = value.date()
         return f"DATE {_sg_literal(str(value))}"
     elif dtype.is_timestamp():
-        return f"TIMESTAMP {_sg_literal(str(value))}"
+        typename = "DATETIME" if dtype.timezone is None else "TIMESTAMP"
+        return f"{typename} {_sg_literal(str(value))}"
     elif dtype.is_time():
         # TODO: define extractors on TimeValue expressions
         return f"TIME {_sg_literal(str(value))}"

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/datetime/index.sql

@@ -1,2 +1,2 @@
 SELECT
-  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS DATETIME)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/datetime/name.sql

@@ -1,2 +1,2 @@
 SELECT
-  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS TIMESTAMP) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS DATETIME) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/string_timestamp/index.sql

@@ -1,2 +1,2 @@
 SELECT
-  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS DATETIME)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/string_timestamp/name.sql

@@ -1,2 +1,2 @@
 SELECT
-  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS TIMESTAMP) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS DATETIME) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/timestamp/index.sql

@@ -1,2 +1,2 @@
 SELECT
-  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  MOD(EXTRACT(DAYOFWEEK FROM CAST('2017-01-01 04:55:59' AS DATETIME)) + 5, 7) AS `DayOfWeekIndex_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_day_of_week/timestamp/name.sql

@@ -1,2 +1,2 @@
 SELECT
-  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS TIMESTAMP) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  INITCAP(CAST(CAST('2017-01-01 04:55:59' AS DATETIME) AS STRING FORMAT 'DAY')) AS `DayOfWeekName_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_timestamp_or_time/datetime/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `tmp`
+  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `tmp`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_timestamp_or_time/string_timestamp/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `tmp`
+  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `tmp`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_timestamp_or_time/timestamp/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `tmp`
+  EXTRACT(hour FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `tmp`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_year/datetime/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_year/string_timestamp/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/bigquery/tests/unit/snapshots/test_compiler/test_literal_year/timestamp/out.sql

@@ -1,2 +1,2 @@
 SELECT
-  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS TIMESTAMP)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`
+  EXTRACT(year FROM CAST('2017-01-01 04:55:59' AS DATETIME)) AS `ExtractYear_datetime_datetime_2017_ 1_ 1_ 4_ 55_ 59`

ibis/backends/tests/test_temporal.py

@@ -1258,6 +1258,12 @@ def test_timestamp_comparison_filter(backend, con, alltypes, df, func_name):
     raises=BaseException,  # pyo3_runtime.PanicException is not a subclass of Exception
     reason="failed to determine supertype of datetime[ns, UTC] and datetime[ns]",
 )
+@pytest.mark.never(
+    ["bigquery"],
+    raises=GoogleBadRequest,
+    # perhaps we should consider disallowing this in ibis as well
+    reason="BigQuery doesn't support comparing DATETIME and TIMESTAMP; numpy doesn't support timezones",
+)
 def test_timestamp_comparison_filter_numpy(backend, con, alltypes, df, func_name):
     ts = np.datetime64("2010-03-02 00:00:00.000123")
 
@@ -2215,11 +2221,6 @@ def test_integer_cast_to_timestamp_scalar(alltypes, df):
     reason="PySpark doesn't handle big timestamps",
     raises=pd.errors.OutOfBoundsDatetime,
 )
-@pytest.mark.notimpl(
-    ["bigquery"],
-    reason="bigquery returns a datetime with a timezone",
-    raises=AssertionError,
-)
 def test_big_timestamp(con):
     # TODO: test with a timezone
     value = ibis.timestamp("2419-10-11 10:10:25")